Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation of forwarding rule for vpc psc endpoint #6864

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Update documentation of forwarding rule for vpc psc endpoint #6864

merged 3 commits into from
Dec 5, 2022

Conversation

IIBenII
Copy link
Contributor

@IIBenII IIBenII commented Nov 23, 2022 •
edited by c2thorn
Loading

Fix this issue: hashicorp/terraform-provider-google#12326

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 41 insertions(+))
Terraform Beta: Diff ( 2 files changed, 100 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 130 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2282
Passed tests 2033
Skipped tests: 244
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccComputeForwardingRule_forwardingRuleVPCPscExample|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeForwardingRule_forwardingRuleVPCPscExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@c2thorn c2thorn requested review from a team and removed request for a team November 23, 2022 20:22
@IIBenII
Copy link
Contributor Author

IIBenII commented Nov 23, 2022

@c2thorn I fix all your feedback, thanks.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 120 insertions(+))
Terraform Beta: Diff ( 2 files changed, 258 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 209 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2282
Passed tests 2036
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeForwardingRule_forwardingRuleVPCPscExample|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccComputeForwardingRule_forwardingRuleVPCPscExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@melinath melinath requested a review from slevenick November 28, 2022 19:02
@slevenick
Copy link
Contributor

Looks like the test fails during import as the returned value is the IP address not the name of the resource. Can you add an ignore import value on that?

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 120 insertions(+))
Terraform Beta: Diff ( 2 files changed, 258 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 209 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2285
Passed tests 2038
Skipped tests: 244
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeForwardingRule_forwardingRuleVPCPscExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_forwardingRuleVPCPscExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@IIBenII
Copy link
Contributor Author

IIBenII commented Nov 28, 2022 •
edited
Loading

@slevenick Everything looks good?

@slevenick slevenick requested review from c2thorn and removed request for c2thorn November 28, 2022 20:46
@slevenick
Copy link
Contributor

Huh, unfortunately I can't merge as @c2thorn requested changes. May need to wait for a re-review from them before this can go in

@IIBenII
Copy link
Contributor Author

IIBenII commented Dec 1, 2022

@slevenick any news on it?

@c2thorn c2thorn merged commit 7b89060 into GoogleCloudPlatform:main Dec 5, 2022
This was referenced Dec 5, 2022
Merged
Merged
Merged
Merged
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022
@IIBenII @kimihrr
Update documentation of forwarding rule for vpc psc endpoint (GoogleC…
108313a 
…loudPlatform#6864)
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
@IIBenII @hao-nan-li
Update documentation of forwarding rule for vpc psc endpoint (GoogleC…
2ea53bb 
…loudPlatform#6864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

@c2thorn c2thorn c2thorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IIBenII @modular-magician @slevenick @c2thorn